-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat errors caused by core/shortcode
blocks like non-block issues
#6675
Conversation
Plugin builds for 8b0e968 are ready 🛎️!
|
Codecov Report
@@ Coverage Diff @@
## develop #6675 +/- ##
=============================================
+ Coverage 76.38% 76.45% +0.06%
- Complexity 6475 6476 +1
=============================================
Files 261 261
Lines 20697 20703 +6
=============================================
+ Hits 15809 15828 +19
+ Misses 4888 4875 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great other than the one small issue regarding the gutenberg
slug.
Summary
Fixes #6667
This PR no longer treats errors generated by the
core/shortcode
block type as if they were WordPress core issues. Instead, all types of error sources are being examined ingetErrorSourceTitle
function in order to find the root cause of the issue.On top of that, Gutenberg is returned as a Source only if it is the sole source of an error (the same logic is used in the other areas of the plugin).
Moreover, this PR fixes an issue where an inexistent
source
property of theblockSources
object is being accessed instead of thetype
property, e.g.:Checklist