Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize reading tail of error log #6652

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Optimize reading tail of error log #6652

merged 6 commits into from
Oct 19, 2021

Conversation

dhaval-parekh
Copy link
Collaborator

Summary

Related: #5939
Amends: #6627

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh self-assigned this Oct 19, 2021
@dhaval-parekh dhaval-parekh marked this pull request as ready for review October 19, 2021 10:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2021 •
edited
Loading

Plugin builds for 47cc8c0 are ready 🛎️!

milindmore22
milindmore22 approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westonruter westonruter added this to the v2.2 milestone Oct 19, 2021
@westonruter westonruter enabled auto-merge October 19, 2021 19:26
@westonruter westonruter changed the title Optimize function that reads error log. Optimize reading tail of error log Oct 19, 2021
@westonruter westonruter disabled auto-merge October 19, 2021 19:27
@westonruter westonruter enabled auto-merge October 19, 2021 19:27
@westonruter westonruter merged commit 0f94add into develop Oct 19, 2021
@westonruter westonruter deleted the feature/5939-support-request-flow branch October 19, 2021 19:32
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@milindmore22 milindmore22 milindmore22 approved these changes

Assignees

@dhaval-parekh dhaval-parekh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dhaval-parekh @westonruter @milindmore22