Add option to keep AMP data upon uninstalling of plugin #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaval-parekh
requested review from
delawski and
pierlon
and removed request for
delawski
|
Plugin builds for c28a210 are ready 🛎️!
|
Codecov Report
@@ Coverage Diff @@
## develop #6632 +/- ##
=============================================
+ Coverage 76.60% 76.62% +0.01%
- Complexity 6311 6312 +1
=============================================
Files 248 248
Lines 19788 19799 +11
=============================================
+ Hits 15159 15170 +11
Misses 4629 4629
Flags with carried forward coverage won't be shown. Click here to find out more.
|
westonruter
requested changes
Oct 5, 2021
includes/uninstall-functions.php
Outdated
| delete_posts(); | ||
| delete_terms(); | ||
| delete_transients(); | ||
| $keep_amp_data = \AMP_Options_Manager::get_option( Option::KEEP_AMP_DATA ); |
There was a problem hiding this comment.
Humm, did you test this on an actual site? The AMP_Options_Manager class is not loaded at uninstallation so this causes a fatal error:
(Perhaps the plugin's autoloader should get initialized during uninstallation.)
westonruter
approved these changes
Oct 5, 2021
delawski
approved these changes
Oct 6, 2021
pierlon
approved these changes
Oct 6, 2021
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| /** | |||
| * Plugin Name: AMP | |||
| * Description: An easier path to great Page Experience for everyone. Powered by AMP. | |||
| * Description: An easier path to great Page Experience for everyone. Powered by AMP. <em class="amp-deletion-notice"><strong>Uninstall Note:</strong> To control whether all data from this plugin is deleted at uninstallation, first activate the plugin, go to the Other section on the Settings screen, and set the “Delete plugin data at uninstall” toggle.</em> | |||
There was a problem hiding this comment.
Wondering if the install note should be on a separate line for better visibility 🤔
Suggested change
| * Description: An easier path to great Page Experience for everyone. Powered by AMP. <em class="amp-deletion-notice"><strong>Uninstall Note:</strong> To control whether all data from this plugin is deleted at uninstallation, first activate the plugin, go to the Other section on the Settings screen, and set the “Delete plugin data at uninstall” toggle.</em> | |
| * Description: An easier path to great Page Experience for everyone. Powered by AMP. <br><em class="amp-deletion-notice"><strong>Uninstall Note:</strong> To control whether all data from this plugin is deleted at uninstallation, first activate the plugin, go to the Other section on the Settings screen, and set the “Delete plugin data at uninstall” toggle.</em> |
| Before | After |
|---|---|
 |
 |
There was a problem hiding this comment.
Ideally, yes. Unfortunately, the br tag is not allowed. Only abbr, acronym, code, em, strong, and a are allowed: https://github.com/WordPress/wordpress-develop/blob/ed9f437fc098ba2c9ba18eda0fa341ecd0476ca9/src/wp-admin/includes/plugin.php#L173-L186
There was a problem hiding this comment.
Oh I see, unfortunate indeed.
Co-authored-by: Pierre Gordon <[email protected]>
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6486
Checklist