Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark amp-story-captions as element containing dynamic content #6628

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

swissspidy
Copy link
Collaborator

Summary

This PR ensures that amp-story-captions (a very new component that first needs to be added with ./bin/amphtml-update.sh) and its child elements can be appropriately styled without the CSS getting stripped.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@swissspidy swissspidy added the Enhancement New feature or improvement of an existing one label Sep 29, 2021
@github-actions
Copy link
Contributor

Plugin builds for 89c827c are ready 🛎️!

@westonruter westonruter merged commit 7ae8cfb into develop Sep 29, 2021
@westonruter westonruter deleted the add/amp-story-captions-style-sanitizer branch September 29, 2021 16:13
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. CSS Enhancement New feature or improvement of an existing one Integration: Web Stories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants