Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests #6620

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Fix E2E tests #6620

merged 2 commits into from
Sep 24, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Sep 22, 2021

Summary

Amends #6618.

This PR temporarily disables the nested-interactive Axe accessibility test rule to allow for the E2E tests to complete without errors. After downgrading the package-lock.json file to v1 in #6618, there have been 2 E2E tests on GitHub that have been erroneously failing which cannot be replicated locally.

The changes in this PR can be reverted once the LTS version on npm is bumped to v7, which is set to happen in the coming weeks.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon
Copy link
Contributor Author

pierlon commented Sep 22, 2021

@delawski Are you replicate the failing E2E tests here?

@delawski
Copy link
Collaborator

@pierlon The tests pass for me both on node 14 and node 16:

Screenshot 2021-09-22 at 11 34 33

Screenshot 2021-09-22 at 11 28 11

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #6620 (4e168ee) into develop (87f2ee3) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6620      +/-   ##
=============================================
+ Coverage      76.42%   76.54%   +0.12%     
- Complexity      6288     6300      +12     
=============================================
  Files            195      246      +51     
  Lines          18918    19736     +818     
=============================================
+ Hits           14458    15107     +649     
- Misses          4460     4629     +169     
Flag Coverage Δ
javascript 78.96% <ø> (?)
php 76.44% <ø> (+0.02%) ⬆️
unit 76.44% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assets/src/common/constants.js 100.00% <0.00%> (ø)
assets/src/components/loading/index.js 100.00% <0.00%> (ø)
assets/src/components/dev-tools-toggle/index.js 80.00% <0.00%> (ø)
...validation/components/amp-document-status/index.js 100.00% <0.00%> (ø)
.../block-validation/hooks/use-amp-document-toggle.js 80.00% <0.00%> (ø)
...s/src/block-validation/components/sidebar/index.js 0.00% <0.00%> (ø)
assets/src/utils/use-window-width.js 80.00% <0.00%> (ø)
...ts/src/common/helpers/test/fixtures/mockClasses.js 100.00% <0.00%> (ø)
...lidation/components/invalid-block-outline/index.js 0.00% <0.00%> (ø)
...dation/hooks/use-validation-error-state-updates.js 85.29% <0.00%> (ø)
... and 43 more

@pierlon pierlon added the Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs label Sep 24, 2021
@pierlon pierlon added this to the v2.2 milestone Sep 24, 2021
@pierlon pierlon marked this pull request as ready for review September 24, 2021 00:36
@github-actions
Copy link
Contributor

Plugin builds for 4e168ee are ready 🛎️!

@westonruter westonruter merged commit 73cfc46 into develop Sep 24, 2021
@westonruter westonruter deleted the fix/e2e-tests branch September 24, 2021 01:04
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants