-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E tests #6620
Merged
Merged
Fix E2E tests #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3295f81
to
41da29c
Compare
45b2b4a
to
e148d65
Compare
@delawski Are you replicate the failing E2E tests here? |
@pierlon The tests pass for me both on node 14 and node 16: |
Codecov Report
@@ Coverage Diff @@
## develop #6620 +/- ##
=============================================
+ Coverage 76.42% 76.54% +0.12%
- Complexity 6288 6300 +12
=============================================
Files 195 246 +51
Lines 18918 19736 +818
=============================================
+ Hits 14458 15107 +649
- Misses 4460 4629 +169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Plugin builds for 4e168ee are ready 🛎️!
|
westonruter
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelogged
Whether the issue/PR has been added to release notes.
Testing
Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Amends #6618.
This PR temporarily disables the
nested-interactive
Axe accessibility test rule to allow for the E2E tests to complete without errors. After downgrading thepackage-lock.json
file to v1 in #6618, there have been 2 E2E tests on GitHub that have been erroneously failing which cannot be replicated locally.The changes in this PR can be reverted once the LTS version on npm is bumped to v7, which is set to happen in the coming weeks.
Checklist