Fix flaky E2E test #6613
Merged
Fix flaky E2E test #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierlon
added
the
Testing
|
Plugin builds for a1d86bb are ready 🛎️!
|
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Example of E2E test failing.
The issue with this E2E test stems from the "busy" state of the save button on the Settings page no longer being present on the page just after the settings are saved. Sometimes when the test is about to assert that the button is "busy", it has already reverted to its disabled state and so the test fails.
This PR removes the assertions related to confirming the busy state of the button since it is not guaranteed it will be present on the page at that point in time and is dependent on how quickly the settings are saved.
Checklist