Fix phpstan v0.12.99 static analysis failures #6600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dhaval Parekh <[email protected]>
|
Plugin builds for 5185da3 are ready 🛎️!
|
2 tasks
|
Just a note, there's another error this PR doesn't resolve but it only occurs with PHP 8:
We could resolve that in #6466 if needs be. |
Yes, please do. |
|
Oh, I forgot that change was part of the other PR as well: https://github.com/ampproject/amp-wp/pull/6456/files#r673052243. Well, if I merge the page caching PR first, then it won't need to be part of #6466. If not, then it will 😄 |
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some commits cherry-picked from #6456.
Checklist