Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svgo Babel config #6562

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Update svgo Babel config #6562

merged 2 commits into from
Aug 25, 2021

Conversation

delawski
Copy link
Collaborator

@delawski delawski commented Aug 25, 2021

Summary

Since the last version bump of svgo to 2.4.0, a console message is being output on each build:

"extendDefaultPlugins" utility is deprecated.
Use "preset-default" plugin with overrides instead.
For example:
{
  name: 'preset-default',
  params: {
    overrides: {
      // customize plugin options
      convertShapeToPath: {
        convertArcs: true
      },
      // disable plugins
      convertPathData: false
    }
  }
}

This PR fixes the Babel config so that the deprecation notice is no longer rendered.

Fixes n/a

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@delawski delawski added the Infrastructure Changes impacting testing infrastructure or build tooling label Aug 25, 2021
@delawski delawski requested a review from pierlon August 25, 2021 10:40
@github-actions
Copy link
Contributor

Plugin builds for fc1b942 are ready 🛎️!

Copy link
Contributor

@pierlon pierlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delawski. LGTM.

@pierlon pierlon merged commit e55553e into develop Aug 25, 2021
@pierlon pierlon deleted the update/svgo-2.4.0-config branch August 25, 2021 17:16
@pierlon pierlon added this to the v2.2 milestone Aug 25, 2021
@westonruter westonruter added dependencies Pull requests that update a dependency file Changelogged Whether the issue/PR has been added to release notes. and removed dependencies Pull requests that update a dependency file labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants