Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert issue templates into issue forms #6543

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Convert issue templates into issue forms #6543

merged 4 commits into from
Sep 20, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Aug 15, 2021

Summary

GitHub now has a feature to allow us to build structured issue forms with required fields and easy-to-follow steps. This PR utilizes this new feature by converting our "bug" and "feature request" issue templates into issue forms.

Most notable changes about the "bug" issue form:

  • The "Additional context" section has been split into separate inputs to allow for better capture of information

  • A "Site Health" input has been added to capture Site Health information

Issue Type Before After
Bug image image
Feature Request image image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added the Project Management Improves process workflow, project management, product definition or similar label Aug 15, 2021
@pierlon pierlon added this to the v2.2 milestone Aug 15, 2021
Comment on lines 45 to 54
- type: dropdown
attributes:
label: AMP plugin template mode
description: Specify which template mode the bug occurs on.
options:
- Standard
- Transitional
- Reader
validations:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue could occur on all template modes. Maybe this should be checkboxes instead? Or there could be an all option? Maybe it shouldn't be required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown input has a multiple attribute that allows for the user to select multiple options, which I think would work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0901533.

- Bug

body:
- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also first thought of markdown when configuring this, but the docs state it's only used for display:

You can use a markdown element to display Markdown in your form that provides extra context to the user, but is not submitted.

Actually, when you click on a textarea input, it transforms into a markdown input:

textarea.mp4

See the demo at https://github.com/pierlon/amp-wp/issues/new?assignees=&labels=Bug&template=bug_report.yml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I had assumed that textarea was for unformatted text.

validations:
required: true

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

validations:
required: true

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

---
_**Do not alter anything below. The following fields will be managed by moderators only.**_

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

---
_**Do not alter anything below. The following fields will be managed by moderators only.**_

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

label: Acceptance Criteria
description: One or more bullet points for acceptance criteria.

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

One or more bullet points for how to technically resolve the issue. For significant Implementation Design,
it is ok use a Google document **accessible by anyone**.

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

label: QA Testing Instructions
description: One or more bullet points to describe how to test the implementation in QA.

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

label: Demo
description: A video or screenshots demoing the implementation.

- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
- type: markdown

@westonruter westonruter merged commit 8ca338f into develop Sep 20, 2021
@westonruter westonruter deleted the issue-forms branch September 20, 2021 16:13
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Project Management Improves process workflow, project management, product definition or similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants