Try adding a method to PairedBrowsing for whether available #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
try/add-paired-browsing-method-for-availability
branch
from
198e023 to
d92c35f
Compare
|
Closing per #6518 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting this out from #6518 because it gets a bit out of the scope of that PR.
What I wasn't happy about in that PR (9e634f3 & 4d2504c) was having the
amp_is_dev_mode() && is_user_logged_in()condition for whether Paired Browsing was available, including across services. Ideally it would be defined once in a single method.This PR doesn't fully work yet.