Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show admin notice to flush cache when user change the template mode or reader theme #6467

Merged
merged 32 commits into from
Oct 8, 2021

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented Jul 20, 2021

Show admin notice to flush cache when user change the template mode or reader theme

Summary

Fixes #4843

4843-add-notice-on-template-change.mov

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh force-pushed the add/4843-add-notice-on-template-change branch from af823f3 to 9f2b9bb Compare July 21, 2021 08:25
@dhaval-parekh
Copy link
Collaborator Author

Need to update this PR after merging #6456 to add check for if the site has page cache enable or not.

@dhaval-parekh dhaval-parekh self-assigned this Jul 21, 2021
@dhaval-parekh dhaval-parekh changed the title Show admin notice to flush cache when user change the template mode o… Show admin notice to flush cache when user change the template mode or reader theme Jul 22, 2021
@dhaval-parekh dhaval-parekh requested a review from pierlon August 10, 2021 07:35
@westonruter westonruter added this to the v2.2 milestone Sep 10, 2021
@dhaval-parekh dhaval-parekh marked this pull request as ready for review September 29, 2021 07:20
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2021

Plugin builds for 0805fab are ready 🛎️!

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there…

@westonruter westonruter enabled auto-merge October 8, 2021 18:38
@westonruter westonruter merged commit 4547bfb into develop Oct 8, 2021
@westonruter westonruter deleted the add/4843-add-notice-on-template-change branch October 8, 2021 18:42
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruct users to flush page cache when changing template modes
2 participants