Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the QA Tester plugin #6427

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Remove the QA Tester plugin #6427

merged 2 commits into from
Jun 29, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jun 26, 2021 •
edited
Loading

Summary

The QA Tester plugin can now be removed from the repo now that is has its own.

Closes #6418
Closes #6413
Closes #6412
Closes #6219

@pierlon pierlon added this to the v2.2 milestone Jun 26, 2021
@pierlon pierlon requested a review from westonruter June 26, 2021 09:14
@pierlon pierlon self-assigned this Jun 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2021 •
edited
Loading

Plugin builds for 0855f31 are ready 🛎️!

@westonruter westonruter force-pushed the remove-qa-tester-plugin branch from ea5a9c3 to b34cb01 Compare June 29, 2021 03:06
@westonruter westonruter enabled auto-merge June 29, 2021 03:07
@westonruter westonruter disabled auto-merge June 29, 2021 03:07
@westonruter westonruter force-pushed the remove-qa-tester-plugin branch from b34cb01 to 19c5774 Compare June 29, 2021 03:08
@westonruter westonruter enabled auto-merge June 29, 2021 03:08
@westonruter
Copy link
Member

Getting an eslint error for an unchanged file in this PRassets/src/block-validation/components/error/error-content.js due to the name external being used.

@pierlon pierlon force-pushed the remove-qa-tester-plugin branch from dcc6f17 to 0855f31 Compare June 29, 2021 16:15
@pierlon
Copy link
Contributor Author

pierlon commented Jun 29, 2021

Getting an eslint error for an unchanged file in this PRassets/src/block-validation/components/error/error-content.js due to the name external being used.

I'm not sure if external is a reserved JSDoc type keyword; it's flagged as an error because it's a SpecialNamePathType. Nevertheless, I've renamed the prop to isExternal in 0855f31.

@pierlon pierlon requested a review from westonruter June 29, 2021 16:18
@westonruter westonruter merged commit 104a2c2 into develop Jun 29, 2021
@westonruter westonruter deleted the remove-qa-tester-plugin branch June 29, 2021 16:20
@delawski
Copy link
Collaborator

QA Passed

There is no QA Tester plugin in the repo anymore.

@westonruter If there is anything more to confirm as part of QA for this ticket, move it back to "Ready for QA" and let me know.

@delawski delawski self-assigned this Nov 30, 2021
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter Awaiting requested review from westonruter

Assignees

@delawski delawski

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pierlon @westonruter @delawski