-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AMP related data while uninstalling plugin. #6422
Remove AMP related data while uninstalling plugin. #6422
Conversation
Plugin builds for 9951f6e are ready 🛎️!
|
475e4cb
to
c487ed2
Compare
It looks like there is more data we can purge:
There may be some others but I think that's all the persistent data. Finally, after deleting all persistent data, we can also purge a lot of transient data, specifically when not using an external object caching plugin (
This is particularly useful for users who have a bad experience with the AMP plugin when they have problems with the AMP plugin filling up their database with transients. By removing all of the transients upon uninstallation, their problem will be solved. |
3ae73c3
to
3f7a4b5
Compare
3f7a4b5
to
80015e0
Compare
80015e0
to
ef7fa2b
Compare
9694d52
to
d2378e3
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this by grabbing a SQL dump via wp db export --extended-insert=false before.sql
and then I uninstalled and did another SQL dump via wp db export --extended-insert=false after.sql
. Then I did diff before.sql after.sql
and looked at the changes, all of which appear to be limited to the scope of what was intended to remove AMP data from the database.
Summary
Fixes #3210
Checklist