Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close latest Gutenberg packages update PR if it is outdated #6380

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jun 14, 2021

Summary

Closes most recent Gutenberg packages update PR if one exists.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added the Infrastructure Changes impacting testing infrastructure or build tooling label Jun 14, 2021
@pierlon pierlon added this to the v2.2 milestone Jun 14, 2021
@pierlon pierlon requested a review from westonruter June 14, 2021 17:30
@pierlon pierlon self-assigned this Jun 14, 2021
@github-actions
Copy link
Contributor

Plugin builds for f6f89a1 are ready 🛎️!

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westonruter
Copy link
Member

As an alternative to this, it could instead update any existing PR that was opened, right?

@westonruter westonruter merged commit f46cdd0 into develop Jun 16, 2021
@westonruter westonruter deleted the close-outdated-pr-when-new-gutenberg-release branch June 16, 2021 00:48
@pierlon
Copy link
Contributor Author

pierlon commented Jun 16, 2021

@westonruter Technically yes, but that may mean merge conflicts could occur which would require manual intervention. Then again, it be could configured to always rebase and force push the changes.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants