Add Bento opt-in

[westonruter]

Summary

To opt-in to serving the Bento versions of AMP components (where available), do:

add_filter( 'amp_bento_enabled', '__return_true' );

Note that this includes the Bento AMP experiment opt-in script, so it will force dev mode as well.

See #6443.

• Add filter to opt-in to Bento mode.
• Enable bento experiment.
• Remove amp attribute from html and add data-ampdevmode to Bento experiment opt-in script. Done in Experiment: Add native img opt-in to prevent conversion to amp-img/amp-anim #6518.
• The image sanitizer no longer converts img to amp-img but instead just ensures dimensions are provided. See Experiment: Add native img opt-in to prevent conversion to amp-img/amp-anim #6518.
• Bento versions of scripts are used instead of latest.
• The amp-runtime is omitted as a dependency of any Bento scripts. (Not yet supported by AMP.)
• Bento stylesheets are enqueued for any Bento components used on the page. (Should these be excluded from CSS concat?) (Not needed when part of AMP page.)
• Disable Optimizer SSR? See Bento components sporadically fail to render on Transformed (SSR'ed) AMP pages amphtml#35485.
• Skip converting any non-Bento components? (Not relevant in the context of this PR.)

Checklist

• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[codecov]

Codecov Report

Merging #6353 (f36363d) into develop (44c641e) will increase coverage by 0.12%.
The diff coverage is 47.50%.

❗ Current head f36363d differs from pull request most recent head 53aac04. Consider uploading reports for the commit 53aac04 to get more accurate results

@@              Coverage Diff              @@
##             develop    #6353      +/-   ##
=============================================
+ Coverage      75.12%   75.24%   +0.12%     
+ Complexity      5912     5902      -10     
=============================================
  Files            190      235      +45     
  Lines          17864    17847      -17     
=============================================
+ Hits           13420    13429       +9     
+ Misses          4444     4418      -26     

Flag	Coverage Δ
javascript	79.84% <ø> (?)
php	75.04% <47.50%> (-0.09%)	⬇️
unit	75.04% <47.50%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ncludes/embeds/class-amp-gallery-embed-handler.php	87.83% <0.00%> (-0.33%)	⬇️
...cludes/embeds/class-amp-playlist-embed-handler.php	95.45% <ø> (-0.20%)	⬇️
...es/sanitizers/class-amp-allowed-tags-generated.php	46.42% <ø> (ø)
...udes/sanitizers/class-amp-core-theme-sanitizer.php	36.27% <12.50%> (-0.87%)	⬇️
includes/class-amp-theme-support.php	84.78% <25.00%> (-1.38%)	⬇️
includes/amp-helper-functions.php	80.41% <54.16%> (-1.14%)	⬇️
includes/sanitizers/class-amp-img-sanitizer.php	92.51% <60.00%> (-5.19%)	⬇️
...s/sanitizers/class-amp-gallery-block-sanitizer.php	100.00% <100.00%> (ø)
includes/sanitizers/class-amp-style-sanitizer.php	86.57% <100.00%> (-0.03%)	⬇️
...nitizers/class-amp-tag-and-attribute-sanitizer.php	97.69% <100.00%> (-0.02%)	⬇️
... and 203 more

[github-actions]

Plugin builds for 76e9c71 are ready 🛎️!

• Download development build
• Download production build

[westonruter]

Note to self: after #6530 is merged, rebase into develop and cherry-pick add/bento-with-amphtml-spec-20210811-spec-update.

[pierlon]

Would you update the prefer_bento arg for AMP_Tag_And_Attribute_Sanitizer to use amp_is_bento_enabled() as well?

[westonruter]

Would you update the prefer_bento arg for AMP_Tag_And_Attribute_Sanitizer to use amp_is_bento_enabled() as well?

Oh yes, indeed.

[milindmore22]

QA Passed

✅ Add filter to opt-in to Bento mode.

✅ Enable bento experiment.

✅ Bento versions of scripts are used instead of the latest. bento scripts are converted to amp scripts 1.0 version

⚠️ Disable Optimizer SSR?

[westonruter]

⚠️ Disable Optimizer SSR?

This one is obsolete. Bento is compatible with Optimized AMP now.