Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newlines from package list before setting step output #6349

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Remove newlines from package list before setting step output #6349

merged 1 commit into from
Jun 2, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jun 2, 2021

Summary

Amends #6302

The package list was not being serialized correctly and so only the first package in the list was set as the step output.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added the Infrastructure Changes impacting testing infrastructure or build tooling label Jun 2, 2021
@pierlon pierlon added this to the v2.2 milestone Jun 2, 2021
@pierlon pierlon requested a review from westonruter June 2, 2021 04:02
@pierlon pierlon self-assigned this Jun 2, 2021
@pierlon pierlon force-pushed the fix/gb-package-list branch from d389fd7 to 12edd83 Compare June 2, 2021 04:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Plugin builds for 12edd83 are ready 🛎️!

@westonruter westonruter merged commit ec3409f into develop Jun 2, 2021
@westonruter westonruter deleted the fix/gb-package-list branch June 2, 2021 05:06
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@pierlon @westonruter