Adds streamlined support request flow #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## develop #6147 +/- ##
=============================================
- Coverage 75.11% 72.80% -2.32%
- Complexity 5858 6046 +188
=============================================
Files 234 236 +2
Lines 17713 18286 +573
=============================================
+ Hits 13306 13313 +7
- Misses 4407 4973 +566
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jwold
approved these changes
Jun 7, 2021
dhaval-parekh
force-pushed
the
feature/send-button
branch
from
f9a3e96 to
ed1bcb6
Compare
swissspidy
reviewed
Jun 25, 2021
dhaval-parekh
force-pushed
the
feature/send-button
branch
from
886cba6 to
1195e3b
Compare
dhaval-parekh
force-pushed
the
feature/send-button
branch
from
1195e3b to
862bfa5
Compare
…lidated_urls without stale results.
delawski
requested changes
Aug 25, 2021
There was a problem hiding this comment.
@dhaval-parekh Thanks for addressing the feedback so far. I've followed up on some comments, so please have a look.
Also, when testing the Support page live, I've noticed some visual issues:
- The main box (
Selectable) doesn't fit into the viewport and overflows to the right. - The "Create support topic" button doesn't see me to centered vertically with the button.
- In case there are no elements in a section (e.g. "Errors (0)"), I don't think there should be an expander next to it (since the expanded pane is empty).
delawski
requested changes
Aug 26, 2021
There was a problem hiding this comment.
@dhaval-parekh Thank you for addressing my previous feedback. I left a few more comments but they are very minor.
delawski
reviewed
Aug 26, 2021
delawski
reviewed
Aug 27, 2021
delawski
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
@dhaval-parekh From my point of view, once the last issue is addressed, the PR is good to go front-end wise. Thank you for your effort!
@pierlon @westonruter Can you have another look when you get a chance?
westonruter
requested changes
Sep 13, 2021
| */ | ||
| public static function is_needed() { | ||
|
|
||
| return current_user_can( 'manage_options' ); |
There was a problem hiding this comment.
I'm surprised the service doesn't need to be Delayed. I would have thought that this would be too early for the user to be logged-in.
westonruter
added a commit
that referenced
this pull request
Sep 13, 2021
2 tasks
westonruter
added a commit
that referenced
this pull request
Sep 14, 2021
Fix tests after merging #6147
westonruter
added a commit
that referenced
this pull request
Sep 14, 2021
…detect-page-caching * 'develop' of github.com:ampproject/amp-wp: (410 commits) Fix tests which presumed Hello Dolly was installed Fix logic inversion for admin bar item check Fix phpstan issues after merging #6147 Improve prop name and description Try fixing failing E2E test Fix the unit test Update `users` resource prop and its description Update assets/src/settings-page/developer-tools.js Set current screen to fix test_enqueue_assets_right_hook_suffix Enable mobile redirection by default Add missing tests for OptionsMenu Update param description Fix typo Allow user-related changes on Options page Improve dev tools toggle description Update Jest snapshot Apply suggestions from code review Add E2E test for dev tools toggle Fix E2E test Fix Other settings box spacing ...
This was referenced Sep 29, 2021
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new submenu page for AMP that enables the users to easily provide necessary diagnostic data to AMP support team, needed for debugging AMP validation errors they are facing on their sites.
WordPress Dashboard ➞ AMP-WP Menu ➞ Support (new submenu page)
It will enable the user to send the data directly from:
Before sending the data, it shows to the user what data is exactly going to be sent.
Once the data is sent, the user will be presented with a UUID that they can copy and provide it to support representative on the support request for further assistance.
Closes: #5939
Screenshots:
Support submenu page
Data preview on the support page
Edit post screen (in the AMP plugin sidebar)
Checklist