Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AMP admin menu item link tooltips when DevTools disabled #6126

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix AMP admin menu item link tooltips when DevTools disabled #6126

merged 1 commit into from
Apr 27, 2021

Conversation

westonruter
Copy link
Member

Summary

Fixes #6124

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1 milestone Apr 27, 2021
@github-actions
Copy link
Contributor

Plugin builds for 2b376e8 are ready 🛎️!

@pierlon
Copy link
Contributor

pierlon commented Apr 27, 2021

When dev tools is disabled, the title of the admin bar menu item is "View non-AMP version":

image

And on the non-AMP page it is "View AMP version":

image

@westonruter westonruter merged commit 5e65134 into develop Apr 27, 2021
@westonruter westonruter deleted the fix/amp-admin-menu-item-tooltips branch April 27, 2021 23:08
@pierlon pierlon mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlon pierlon pierlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

Incorrect title for admin bar menu item when dev tools is disabled and on an AMP page
2 participants
@westonruter @pierlon