-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ESLint on PR fork without generating report #5876
Conversation
b893674
to
824b36d
Compare
Plugin builds for 824b36d are ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will prevent the following from happening as in #5871:
Correct?
Why again is it that without this change, the step is skipped?
I believe I'll also need to remove this from the required checks for the tests to pass:
It should not have been showing in the first place since the action that creates the check did not run at all.
I wonder if that's the reason why the check appears even when the
I suppose you mean the "Annotate code linting results" step. That was set to skip in #5656. |
@@ -68,7 +68,13 @@ jobs: | |||
- name: Validate package.json | |||
run: npm run lint:pkg-json | |||
|
|||
- name: Detect coding standard violations (ESLint) | |||
- name: Detect ESLint coding standard violations | |||
if: github.event.pull_request.head.repo.fork == true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, npm run lint:js:report
also does the linting, so that is why this is is limited to forks.
Summary