Strip path suffix from pagenum links to fix the posts pagination #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@milindmore22 Would you test this to confirm it is fixing the issue you reported? |
Codecov Report
@@ Coverage Diff @@
## develop #5862 +/- ##
=============================================
+ Coverage 75.15% 75.18% +0.03%
- Complexity 5657 5663 +6
=============================================
Files 210 210
Lines 16987 17009 +22
=============================================
+ Hits 12766 12788 +22
Misses 4221 4221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Plugin builds for c467d11 are ready 🛎️!
|
milindmore22
approved these changes
Feb 8, 2021
|
@pierlon Ready for review. |
pierlon
reviewed
Feb 10, 2021
tests/php/src/PairedRoutingTest.php
Outdated
| $this->assertFalse( has_action( 'wp_head', 'amp_add_amphtml_link' ) ); | ||
| $this->assertEquals( $using_path_suffix, $this->instance->is_using_path_suffix() ); |
There was a problem hiding this comment.
This check was already done on line 463. Is it necessary once more?
There was a problem hiding this comment.
Ah no. It was redundant. Removed in c467d11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5861
Checklist