Only run PHPStan (on all PHP files) in pre-commit hook if there is a modified PHP file #5747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found that our
pre-commit
hook was eagerly running PHPStan even when no modified PHP files were staged. We originally were going to include PHPStan in lint-staged via #5424 but reverted in #5438 since it's important for all PHP files to be included in the analysis. This PR conditionally runs PHPStan on all PHP files if any PHP file is modified.Logic inspired by example in lint-staged docs:
Checklist