Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate obsolete amp_post_template_add_analytics_script() #5722

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Deprecate obsolete amp_post_template_add_analytics_script() #5722

merged 1 commit into from
Dec 21, 2020

Conversation

westonruter
Copy link
Member

Summary

The amp_post_template_add_analytics_script() function is obsolete now that legacy Reader mode templates are sent through the post-processor and AMP scripts are automatically added.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1 milestone Dec 21, 2020
@westonruter westonruter added Tech Debt Deprecations, inefficiencies, code health WS:Core Work stream for Plugin core labels Dec 21, 2020
@westonruter westonruter force-pushed the deprecate/amp_post_template_add_analytics_script branch from e6c4c8c to 1ec0c23 Compare December 21, 2020 01:54
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2020 •
edited
Loading

Plugin builds for 1ec0c23 are ready 🛎️!

@westonruter westonruter merged commit aaa4d37 into develop Dec 21, 2020
@westonruter westonruter deleted the deprecate/amp_post_template_add_analytics_script branch December 21, 2020 17:02
@pierlon pierlon self-assigned this Apr 24, 2021
@pierlon
Copy link
Contributor

pierlon commented Apr 26, 2021

QA Passed

Verified that calling the amp_post_template_add_analytics_script() function now results in a deprecation notice being printed:

Deprecated: amp_post_template_add_analytics_script is <strong>deprecated</strong> since version 2.1 with no alternative available. in /app/public/core-dev/src/wp-includes/functions.php on line 4877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlon pierlon pierlon approved these changes

Assignees

@pierlon pierlon

Labels
Tech Debt Deprecations, inefficiencies, code health WS:Core Work stream for Plugin core
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @pierlon