Improve string rendition of float numbers for sizers #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
added
Optimizer
WS:Perf
|
Plugin builds for 826b5fe are ready 🛎️!
|
westonruter
approved these changes
Oct 10, 2020
|
Should this be milestones for 2.1? If merged into the 2.0 branch won't it it fail tests since the amp-toolbox optimizer is pinned? |
|
@schlessera I'm milestoning for 2.1 for now, and we can re-milestone for 2.0.5 based on whether cherry-picking will cause issues on the 2.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR gets the code in sync with an upstream fix I had submitted to improve the string rendition of float numbers for sizers. Instead of using sizer dimensions like
80.0000%, it uses80%instead (while still keeping the max precision of 4 decimals in place where needed).Related: ampproject/amp-toolbox#930
Checklist