Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove post-processor cache #4391

Merged
merged 4 commits into from
Mar 15, 2020
Merged

Remove post-processor cache #4391

merged 4 commits into from
Mar 15, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Mar 15, 2020

Summary

This PR removes code related to the post-processor cache, which includes:

  • Removing the ETag HTTP header and the support for sending 304 Not Modified responses
  • Removing the 'Caching' section and option on the settings page
    • Remove the enable_response_caching option upon upgrade to v1.5.0
  • Removing all notices related to object caching and post-processor cache

Fixes #4178

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Mar 15, 2020
@westonruter westonruter added this to the v1.5 milestone Mar 15, 2020
@westonruter
Copy link
Member

I love how the work on the Optimizer and this PR both have removed a bunch of code from AMP_Theme_Support. 🎉

@westonruter westonruter merged commit 8150a62 into develop Mar 15, 2020
@westonruter westonruter deleted the ehancement/4178-page-caching branch March 15, 2020 23:07
@westonruter westonruter mentioned this pull request Apr 6, 2020
Closed
@westonruter westonruter mentioned this pull request Jun 24, 2020
Closed
@schlessera schlessera added Caching WS:Perf Work stream for Metrics, Performance and Optimizer labels Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Caching cla: yes Signed the Google CLA WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Eliminate post-processor cache
4 participants
@pierlon @westonruter @schlessera @googlebot