Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently import components from block-editor package #2561

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Consistently import components from block-editor package #2561

merged 2 commits into from
Jun 11, 2019

Conversation

swissspidy
Copy link
Collaborator

These are currently proxied through the editor package, which is the deprecated way of importing them.

@swissspidy
Consistently import components from block-editor package
536e123 
These are currently proxied through the editor package, which is the deprecated way of importing them.
@swissspidy swissspidy added this to the v1.2 milestone Jun 11, 2019
@swissspidy swissspidy requested a review from miina June 11, 2019 10:02
@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 11, 2019
@swissspidy swissspidy merged commit 647590f into develop Jun 11, 2019
@swissspidy swissspidy deleted the fix/block-editor-import branch June 11, 2019 12:14
westonruter added a commit that referenced this pull request Jun 11, 2019
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into update/gu…
7a18a20 
…ide-lighter-media

* 'develop' of github.com:ampproject/amp-wp:
  Update dependency css-loader to v3 (#2563)
  Consistently import components from block-editor package (#2561)
  Refactor AMP modes (#2550)
  Update dependency webpack-cli to v3.3.4 (#2558)
@swissspidy swissspidy mentioned this pull request Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miina miina miina approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@swissspidy @miina @googlebot