Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object-fit:cover style of Twenty Nineteen featured image #1619

Merged
merged 3 commits into from
Nov 16, 2018

Conversation

westonruter
Copy link
Member

The solution here mirrors what was done for the header image in Twenty Seventeen (in #1074).

See fix deployed to https://paired-ampconfdemo.pantheonsite.io/2018/11/16/bison/?amp

Before

screen shot 2018-11-15 at 10 25 32 pm

After

screen shot 2018-11-15 at 10 25 46 pm

See #1604.

@westonruter westonruter added this to the v1.0 milestone Nov 16, 2018
@kienstra
Copy link
Contributor

Approved

Hi @westonruter,
This looks good.

I also saw that the featured image displays as expected with this PR:
featured-image-as-expected

@westonruter westonruter merged commit 7f60dd5 into 1.0 Nov 16, 2018
@swissspidy swissspidy deleted the fix/twentynineteen-featured-image branch June 18, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants