Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Server-Timing header if not WP_DEBUG and user cannot manage_options #1354

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

westonruter
Copy link
Member

This prevents perhaps undesirable leaking of some server implementation details, as well as it reduces response header weight.

Originally requested by @igkuz in #990 (comment)

@westonruter westonruter added this to the v1.0 milestone Aug 24, 2018
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@amedina amedina merged commit 0401d5e into develop Aug 24, 2018
@westonruter westonruter deleted the update/conditionally-send-server-timing branch August 24, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants