Ensure all sanitizers run when building featured image #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
suggested changes
Apr 20, 2018
There was a problem hiding this comment.
Works As Expected
Question About Argument
Hi @westonruter,
Thanks, this works well. Images still display as expected in the legacy template (which uses AMP_Post_Template).
There's only one question here, but it might not need any action. I'm happy to approve this soon.
| @@ -349,7 +349,7 @@ private function build_post_featured_image() { | |||
|
|
|||
| list( $sanitized_html, $featured_scripts, $featured_styles ) = AMP_Content_Sanitizer::sanitize( | |||
| $featured_html, | |||
| array( 'AMP_Img_Sanitizer' => array() ), | |||
| amp_get_content_sanitizers( $post_id ), | |||
There was a problem hiding this comment.
Should this pass a WP_Post instead of $post_id? It looks like amp_get_content_sanitizers() expects a WP_Post as the argument.
This ensures that the amp-anim script, for example, will be assured to be included. It also ensures that if a plugin adds other markup to a featured image via the post_thumbnail_html filter that it will be properly sanitized.
westonruter
force-pushed
the
fix/featured-image-anim
branch
from
d5b9127
to
5045563
Compare
kienstra
approved these changes
Apr 20, 2018
|
Approved Hi @westonruter, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression introduced by #882 in c62dad6.
This ensures that the
amp-animscript, for example, will be assured to be included. It also ensures that if a plugin adds other markup to a featured image via thepost_thumbnail_htmlfilter that it will be properly sanitized.Fixes #1090.