Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime CSS minification, !important replacement, and tree shaking #1048

Merged
merged 32 commits into from
Apr 6, 2018
Merged

Add runtime CSS minification, !important replacement, and tree shaking #1048

merged 32 commits into from
Apr 6, 2018

Commits on Mar 31, 2018

  1. Add sabberworm/php-css-parser composer dependency

    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    48a538b View commit details
    Browse the repository at this point in the history

  2. Add initial Server Timing response headers 

    See #990
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    0e994a9 View commit details
    Browse the repository at this point in the history

  3. Use sabberworm/php-css-parser to sanitize CSS 

    * Compress CSS output with compact format, removing whitespace and comments.
* Reduce length of generated class names for inline styles.
* Unify logic for handling inline style attributes with handling stylesheets in style/link.
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    8271fac View commit details
    Browse the repository at this point in the history

  4. Delete illegal properties (behavior and -moz-binding)

    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    a96b39b View commit details
    Browse the repository at this point in the history

  5. Include sabberworm/php-css-parser from composer in build; always comp… 

    …oser install in Travis build
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    06fca39 View commit details
    Browse the repository at this point in the history

  6. Add check for composer install; update contributing with dev installa… 

    …tion instructions
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    c27e9a2 View commit details
    Browse the repository at this point in the history

  7. Add tests for AMP_Response_Headers

    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    8ef82f7 View commit details
    Browse the repository at this point in the history

  8. Add missing phpdoc for functions in amp.php

    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    e16aba2 View commit details
    Browse the repository at this point in the history

  9. Improve handling of style[amp-keyframes] by merging multiples and ens… 

    …uring end of body
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    036c631 View commit details
    Browse the repository at this point in the history

  10. Transform !important property qualifiers into rules with more specifi… 

    …c selectors (following replace-important package)

Eliminate illegal_css_important_qualifier validation error now that transformed
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    fd04b20 View commit details
    Browse the repository at this point in the history

  11. Remove illegal @-rules and ensure properties inside @media/@supports … 

    …are processed
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    5da10f3 View commit details
    Browse the repository at this point in the history

  12. Include css_spec from validator in AMP_Allowed_Tags_Generated

    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    523d5ee View commit details
    Browse the repository at this point in the history

  13. Capture full cdata spec for amp-keyframes and amp-custom to use for v… 

    …alidation
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    1889f70 View commit details
    Browse the repository at this point in the history

  14. Discontinue deleting scroll/auto values for overflow properties since… 

    … not forbidden
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    9187710 View commit details
    Browse the repository at this point in the history

  15. Add parsing and validation of keyframes 

    * Handle CSS parse errors.
* Let spec inform which @-rules are allowed.
* Improve handling of vendor-prefixed properties in whitelist/blacklists.
* Inform when !important qualifier is removed from rules with selectors (that aren't keyframes).
    @westonruter
    westonruter committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    3d18b8a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2018

  1. Ensure stylesheets are output in legacy post templates

    @westonruter
    westonruter committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    f245a8f View commit details
    Browse the repository at this point in the history

  2. Bump required PHP to 5.3.2 for sake of php-css-parser

    @westonruter
    westonruter committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    6c49807 View commit details
    Browse the repository at this point in the history

  3. Add class-based selector tree shaking of CSS rules

    @westonruter
    westonruter committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    3e3266b View commit details
    Browse the repository at this point in the history

  4. Further reduce CSS size by deleting individual selectors that lack va… 

    …lid class references
    @westonruter
    westonruter committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    6b5f97e View commit details
    Browse the repository at this point in the history

  5. Prevent :not() pseudo-selectors from tree shaking classes erroneously

    @westonruter
    westonruter committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    ae68eee View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. Remove attribute selectors prior to searching for class names to prev… 

    …ent false matches
    @westonruter
    westonruter committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    6d4778e View commit details
    Browse the repository at this point in the history

  2. Simplify accounting for used class names when tree shaking

    @westonruter
    westonruter committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    2693f7e View commit details
    Browse the repository at this point in the history

  3. Make font-face source urls non-relative; replace data: URLs with (ass… 

    …umed) file URLs
    @westonruter
    westonruter committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    faef934 View commit details
    Browse the repository at this point in the history

  4. Use expiring transients when no external object cache present

    @westonruter
    westonruter committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    cb3cc2c View commit details
    Browse the repository at this point in the history

  5. Handle selector specificity variability; give high specificity to rul… 

    …es from style attrs

* Reduce length of dummy ID from "FK_ID" to just "_".
* Ensure !important added to selectors on html element are handled.
    @westonruter
    westonruter committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    346eae2 View commit details
    Browse the repository at this point in the history

  6. Convert all URLs (including background-image) to have absolute paths

    @westonruter
    westonruter committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    14c22c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. Merge branch 'develop' of https://github.com/Automattic/amp-wp into a… 

    …dd/css-tree-shaking
    @westonruter
    westonruter committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    313f0b9 View commit details
    Browse the repository at this point in the history

  2. Prevent filtering selectors which reference dynamic elements

    @westonruter
    westonruter committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    bede9de View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Skip removing style rules when the total CSS does not exceed max_bytes

    @westonruter
    westonruter committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    adb1fb1 View commit details
    Browse the repository at this point in the history

  2. Verify existence of font file source for data: URL

    @westonruter
    westonruter committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    a8fddf2 View commit details
    Browse the repository at this point in the history

  3. Add tests for validation errors raised during style sanitization

    @westonruter
    westonruter committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    3cd9fdd View commit details
    Browse the repository at this point in the history

  4. Add testing for remove_unused_rules=sometimes and excessive_css

    @westonruter
    westonruter committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    efd1965 View commit details
    Browse the repository at this point in the history