-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for AMP_Theme_Support #1034
Commits on Mar 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ce66658 - Browse repository at this point
Copy the full SHA ce66658View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe5527 - Browse repository at this point
Copy the full SHA 1fe5527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7232ab5 - Browse repository at this point
Copy the full SHA 7232ab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c6402 - Browse repository at this point
Copy the full SHA b3c6402View commit details -
Skip printing paths-scope because it causes push builds to be truncat…
…ed (and fail) for unknown reason See xwp/wp-dev-lib#270
Configuration menu - View commit details
-
Copy full SHA for 97dcdf1 - Browse repository at this point
Copy the full SHA 97dcdf1View commit details
Commits on Mar 27, 2018
-
Add 2 PHPUnit tests for AMP_Theme_Support.
Test init() and redirect_canonical_amp(). @todo continue with these, and consider a better way to test redirect_canonical_amp(). That uses wp_safe_redirect, which throws an error.
Ryan Kienstra committedMar 27, 2018 Configuration menu - View commit details
-
Copy full SHA for 4c17c67 - Browse repository at this point
Copy the full SHA 4c17c67View commit details -
Test 2 more methods in AMP_Theme_Support.
is_customize_preview_iframe() and register_paired_hooks().
Ryan Kienstra committedMar 27, 2018 Configuration menu - View commit details
-
Copy full SHA for 4d70aa9 - Browse repository at this point
Copy the full SHA 4d70aa9View commit details -
Test 3 more methods in AMP_Theme_Support.
Test add_hooks, send_header(), and register_content_embed_handlers().
Ryan Kienstra committedMar 27, 2018 Configuration menu - View commit details
-
Copy full SHA for ac6cac1 - Browse repository at this point
Copy the full SHA ac6cac1View commit details
Commits on Mar 28, 2018
-
Test 3 more methods in AMP_Theme_Support.
Test methods related to AMP templates, and get_current_canonical_url().
Ryan Kienstra committedMar 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 92ada3b - Browse repository at this point
Copy the full SHA 92ada3bView commit details -
Add comment form-related PHPUnit tests.
Test 2 methods: get_comment_form_state_id() and filter_comment_form_defaults().
Ryan Kienstra committedMar 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 93bf043 - Browse repository at this point
Copy the full SHA 93bf043View commit details -
Remove the conditional around the add_action for preview scripts.
There's a check for is_customize_preview() around add_action(). But the callback dequeue_customize_preview_scripts() has its own check for is_customize_preview_iframe(). And that has a check for is_customize_preview(). So this ensures that the body of the callback never runs. Maybe I misread the intent of this, though. This also adds unit tests.
Ryan Kienstra committedMar 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 7c704ae - Browse repository at this point
Copy the full SHA 7c704aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f90c40a - Browse repository at this point
Copy the full SHA f90c40aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 912ea33 - Browse repository at this point
Copy the full SHA 912ea33View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4dedbb - Browse repository at this point
Copy the full SHA e4dedbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce68491 - Browse repository at this point
Copy the full SHA ce68491View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9caf29b - Browse repository at this point
Copy the full SHA 9caf29bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb6bba - Browse repository at this point
Copy the full SHA cdb6bbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b75fae - Browse repository at this point
Copy the full SHA 1b75faeView commit details -
Remove extra variable declarations.
These variables are only used once, so they can simply be passed to the array.
Ryan Kienstra committedMar 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 2540e86 - Browse repository at this point
Copy the full SHA 2540e86View commit details -
Remove extra phpcs:ignore comments.
There's already a phpcs:disable at the top of the method. And a phpcs:enable at the bottom.
Ryan Kienstra committedMar 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 86f13fb - Browse repository at this point
Copy the full SHA 86f13fbView commit details
Commits on Mar 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b365e00 - Browse repository at this point
Copy the full SHA b365e00View commit details
Commits on Mar 30, 2018
-
Merge in 0.7, resolve conflicts.
There was a minor conflict in: test-class-amp-theme-support.php. Retain both edits.
Ryan Kienstra committedMar 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 9e87ea6 - Browse repository at this point
Copy the full SHA 9e87ea6View commit details
Commits on Mar 31, 2018
-
Fix a failed unit test by setting $wp_styles to null.
Before, merging in 0.7, there was an amp-default <link>. But test_validate_non_amp_theme() also output that. And that stored the script in $wp_styles->done. So it wasn't output again, and the test failed. So reset $wp_styles, so it gets re-instantiated.
Ryan Kienstra committedMar 31, 2018 Configuration menu - View commit details
-
Copy full SHA for 71b83fc - Browse repository at this point
Copy the full SHA 71b83fcView commit details