Fix enqueueing amp-runtime and handling comment submissions in paired mode #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
fix/paired-mode-xhr
branch
from
2364049
to
213d195
Compare
kienstra
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
This pull request looks good. Nice use of WP_UnitTestCase::go_to().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028:
When in paired mode, if I submit the comment at https://paired-ampconfdemo.pantheonsite.io/2018/02/06/are-you-there-lebron-its-me-lebron-a-superstars-ultimate-pep-talk/amp/ then it will redirect me to the non-AMP article. The
comment_post_redirectfilter should be making sure that if paired mode is enabled that it redirects to the AMP version of the post instead.Related: when in non-paired mode such as at https://paired-ampconfdemo.pantheonsite.io/2018/02/06/are-you-there-lebron-its-me-lebron-a-superstars-ultimate-pep-talk/#respond I cannot submit the form. Why? Because the
amp-runtimescript is erroneously getting enqueued. This results in:This regression was introduced in #1023
_wp_amp_action_xhr_convertedreally should be used to determine whether the logic inAMP_Theme_Support::handle_xhr_request()runs.