Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do redirect if amp comments_live_list support is not declared; vary comment success message by approval status #1029

Merged
merged 6 commits into from
Mar 21, 2018
Merged

Do redirect if amp comments_live_list support is not declared; vary comment success message by approval status #1029

merged 6 commits into from
Mar 21, 2018

Commits on Mar 20, 2018

  1. add amp-redirect if amp-live-list is not declared

    @DavidCramer
    DavidCramer committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    fb649cc View commit details
    Browse the repository at this point in the history

  2. Add message to response based on comment approval

    @DavidCramer
    DavidCramer committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    6f00f20 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2018

  1. Fix and refactor XHR handling 

    * Explicitly limit handle_xhr_request to POST requests.
* Make sure original status header is sent back in wp_die() call.
* Fix reading of amp theme support flag since get_theme_support() returns an array of args.
* Add missing paragraph surrounding success message template.
* Fix moderation comment to ensure default core string is re-used.
* Fix PHP notice in regards to additional comment_live_list theme support flag being present.
* Remove obsolete comments.
* Simplify success message.
* Add phpdoc for amp_comment_posted_message filter.
* Pass back success message in same way as error message is returned as named variable.
* Add missing tests and introduce \AMP_Theme_Support::send_header() to avoid having to runInSeparateProcess.
    @westonruter
    westonruter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    a0fce3f View commit details
    Browse the repository at this point in the history

  2. Add validation for __amp_source_origin

    @westonruter
    westonruter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    1e32d6c View commit details
    Browse the repository at this point in the history

  3. Use scheme-less URL for redirect if non-HTTPS

    @westonruter
    westonruter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    5c96324 View commit details
    Browse the repository at this point in the history

  4. Improve comments regarding XHR handling 

    Improve default status_code handling
    @westonruter
    westonruter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    8da1a36 View commit details
    Browse the repository at this point in the history