Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist Sanitizer Improvements #689

Closed
4 of 6 tasks
mjangda opened this issue Apr 28, 2017 · 2 comments
Closed
4 of 6 tasks

Whitelist Sanitizer Improvements #689

mjangda opened this issue Apr 28, 2017 · 2 comments
Assignees
@mjangda @amedina
Labels
Enhancement New feature or improvement of an existing one P0 High priority Sanitizers Task Tasks which do not involve engineering Validation

Comments

@mjangda
Copy link
Contributor

mjangda commented Apr 28, 2017 •
edited by westonruter
Loading

With the sanitizer merged as part of #600, it would be nice to have the following updates:

  • Make filters into args that args that are passed via the constructor (follows the convention of other sanitizers). There are some filters we can probably remove for now as well.
  • Remove test-data; not used.

Spec Generation Script

Code Quality

  • Flatten out is_amp_allowed_attribute
  • Flatten out check_attr_spec_rule_mandatory
  • Minor: Update constants in AMP_Spec to be uppercase
@mjangda mjangda self-assigned this Apr 28, 2017
@amedina amedina self-assigned this Jul 5, 2017
mjangda added a commit that referenced this issue Aug 4, 2017
@mjangda
rm filters from Tag/Attribute sanitizer constructor
4e2d285 
Follows the pattern of no actions inside sanitizers. Modifications to
their behaviour should be done via args to avoid global pollution via
filters.

See #689
@mjangda mjangda mentioned this issue Aug 4, 2017
Merged
@amedina amedina added P0 High priority Enhancement New feature or improvement of an existing one Task Tasks which do not involve engineering labels Aug 11, 2017
@westonruter westonruter mentioned this issue Nov 7, 2017
Closed
@westonruter westonruter added this to the Next Major milestone Nov 7, 2017
@kienstra kienstra mentioned this issue Dec 11, 2017
Merged
@westonruter
Copy link
Member

@mjangda do you have any further info on what you had in mind for flattening out those two methods?

Otherwise, I think this issue can be closed.

@westonruter
Copy link
Member

We can re-open if need be.

@ThierryA ThierryA removed the Sprint 5 label Mar 8, 2018
@ThierryA ThierryA modified the milestone: v0.7 Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjangda mjangda

@amedina amedina

Labels
Enhancement New feature or improvement of an existing one P0 High priority Sanitizers Task Tasks which do not involve engineering Validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mjangda @westonruter @amedina @ThierryA