Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dropdown for analytics type instead of input and add a link to vendor lists. #6367

Closed
milindmore22 opened this issue Jun 10, 2021 · 4 comments · Fixed by #6894
Closed
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone

Comments

@milindmore22
Copy link
Collaborator

milindmore22 commented Jun 10, 2021

Enhancement Description

Although we have clear instructions on the settings panel of analytics, people are still making mistakes while adding analytics configurations. it's been observed from support forums that most of the time they don't enter anything in type input or make a mistake while entering input to avoid let's provide a dropdown box.

Scenario 1: Include all analytics vendors in a dropdown.

Scenario 2: Include only top/popular 10 ones with the option to input for more.

Following are the top 10 analytics vendors (I consider them top 10 feel free to update the list if needed ) we should consider in the dropdown with input, also please check the possibility of pre-filled vendor configurations for these 10 vendors.

  1. Google Analytics
  2. Google Tag
  3. Google Ads
  4. Adobe Analytics
  5. Alexa Metrics
  6. Baidu analytics
  7. Facebook Pixel
  8. New Relic
  9. Nielsen
  10. Yandex Metrica

Screenshots

image

Additional context

  • WordPress version: 5.7.2
  • Plugin version: 2.1.2
  • Gutenberg plugin version (if applicable):
  • AMP plugin template mode: All Modes
  • PHP version: 7.4
  • OS: Mac
  • Browser: chrome, safari
  • Device: Macbook Air

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@milindmore22 milindmore22 added the Enhancement New feature or improvement of an existing one label Jun 10, 2021
@westonruter
Copy link
Member

The list of vendors is available in this directory: https://github.com/ampproject/amphtml/tree/main/extensions/amp-analytics/0.1/vendors

We could have a JSON file which is constructed as part of the build that obtains the list to include with the plugin.

@pooja-muchandikar
Copy link

The drop-down is in place for Analytics section

image


But as per the following description, I think on selecting the input from drop-down the vendors should get prefilled.

we should consider in the dropdown with input, also please check the possibility of pre-filled vendor configurations for these 10 vendors.

@milindmore22
Copy link
Collaborator Author

examples

@westonruter
Copy link
Member

But as per the following description, I think on selecting the input from drop-down the vendors should get prefilled.

we should consider in the dropdown with input, also please check the possibility of pre-filled vendor configurations for these 10 vendors.

We can address this in a follow-up issue.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants