Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum PHP version should be increased to 5.3.6 #1406

Closed
bobbrodie opened this issue Sep 6, 2018 · 2 comments
Closed

Minimum PHP version should be increased to 5.3.6 #1406

bobbrodie opened this issue Sep 6, 2018 · 2 comments
Milestone
v1.0

Comments

@bobbrodie
Copy link

bobbrodie commented Sep 6, 2018 •
edited
Loading

In #891, the minimum PHP version is set to 5.3, however http://php.net/manual/en/domdocument.savehtml.php is not available until 5.3.6. While many people will be running on more recent versions of PHP, there are folks out there that are on versions of 5.3 that are lower than 5.3.6. This causes an issue where the post content will not show on AMP pages.
@westonruter westonruter added this to the v1.0 milestone Sep 6, 2018
@westonruter
Copy link
Member

Good catch. Yes, I see that the $node parameter was added in 5.3.6:

image

Opening a PR…

@westonruter westonruter mentioned this issue Sep 6, 2018
Merged
@westonruter
Copy link
Member

See #1407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@bobbrodie @westonruter