Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization to use HTML instead of XML #891

Merged
merged 3 commits into from
Jan 24, 2018

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jan 23, 2018

  • Updates minimum required PHP version to 5.3. The AMP plugin currently supports PHP 5.2. Because of this it has meant that DOMDocument::saveHTML($node) has not available since it was introduced in 5.3. Using saveXML instead causes other problems, including injection of CDATA sections, unbooleanized attributes, and self-closing tags. Instead of trying to work around all of these issues to continue supporting PHP 5.2, I think it would be more sensible to update the minimum requirement to PHP 5.3.
  • Fully deprecates blacklist sanitizer.

This prevents CDATA sections, erroneous self-closing tags, and un-booleanized attributes from happening.
@westonruter
Copy link
Member Author

Rebased to resolve merge conflict. Former HEAD was 25b1fd9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants