Fix test flakiness caused by Puppeteer state management #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
force-pushed
the
fix-security
branch
6 times, most recently
from
bb365de
to
2179829
Compare
powerivq
changed the title
powerivq
force-pushed
the
fix-security
branch
13 times, most recently
from
7a757fd
to
49d09ca
Compare
erwinmombay
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes occasional test failures caused by Puppeteer page not properly closed before the next test runs. We fix it by awaiting
page.close()(old logic is having it in try/finally). In the event of test failure, not closing would not be critical anyways, and calling close would not help much.