Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use new thread instead of background blocking thread #20

Merged
merged 1 commit into from
Apr 29, 2022
Merged

fix: use new thread instead of background blocking thread #20

merged 1 commit into from
Apr 29, 2022

Conversation

bohan-amplitude
Copy link
Contributor

Summary

  1. create new consumer thread when event pushed to storage
  2. remove old background blocking consumer thread

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bohan-amplitude bohan-amplitude merged commit 24f807f into amplitude:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@kevinpagtakhan kevinpagtakhan Awaiting requested review from kevinpagtakhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bohan-amplitude @justin-fiedler @qingzhuozhen