Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to follow the project README.md to set up my local environment there were a few hiccups that I first had to address in the solution. This may be good to have updated to make it a bit smoother for the next person to onboard. Although there is probably more left to configure I believe this is the bare minimum that needs to be addressed in order to get the app up and running locally. If there are other obvious things that can be updated in the README perhaps this is a good time to do so?
Command:
bundle exec rake dummy:posts
Error:
NameError: uninitialized constant Faker::Books::HitchhikersGuideToTheGalaxy
Resolution: After looking at Faker documentation, I see that this one does exist: Faker::Movies::HitchhikersGuideToTheGalaxy.quote (Movies instead of Books). So I changed Books to Movies to fix it locally
Command:
react-scripts start
Error:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
Resolution: I found facebook/create-react-app#8499 and also https://stackoverflow.com/questions/60234640/typeerror-err-invalid-arg-type-the-path-argument-must-be-of-type-string-re
So I bumped up react-scripts version 3.3.0 --> 3.4.0 to fix it locally.
Command:
rails s
Error:
bucket.rb:684:in 'extract_name': missing required option :name (ArgumentError)
Resolution: added
S3_BUCKET
my environment variables, and modified README to denote it as required.