Remove BUILD_DYNRT_LIBS, install missing headers and export cmake targets#4
Closed
JackBoosY wants to merge 1 commit intoampl:masterfrom
Closed
Remove BUILD_DYNRT_LIBS, install missing headers and export cmake targets#4JackBoosY wants to merge 1 commit intoampl:masterfrom
JackBoosY wants to merge 1 commit intoampl:masterfrom
Conversation
mapgccv
reviewed
Jan 28, 2021
Contributor
There was a problem hiding this comment.
@JackBoosY first of all thanks for the pull request - and apologies for this late reply.
On the changes you have made:
- CRT linkage should follow the C_FLAGS/CXX_FLAGS setting instead of specifying it through options, so I deleted BUILD_DYNRT_LIBS.
We use this cmake file internally for linking ASL against multiple targets, some of which have different requirements in terms of linkage, may they be dynrt or large mcmodel, It is therefore convenient (for our purposes) to have different targets exported by this.
- The exported files stdio1.h and arith.h are not installed.
Noted, I will merge those changes
- Export cmake targets so we can easily to use this library using find_package(ampl-asl CONFIG) / target_link_libraries(main PRIVATE ampl-asl).
Noted. Since I will be other modifications, I'll add those changes manually if you don't mind.
Contributor
|
Closing because the relevant changes had been merged manually. Feel free to reopen if something is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C_FLAGS/CXX_FLAGSsetting instead of specifying it through options, so I deletedBUILD_DYNRT_LIBS.stdio1.handarith.hare not installed.find_package(ampl-asl CONFIG)/target_link_libraries(main PRIVATE ampl-asl).