[CORE-674] Update the ach gem to support Ruby 2.7 and up #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drench
force-pushed
the
update_the_ach_gem_to_support_ruby_2_7_and_u_CORE-674
branch
from
30bb972 to
4b0f233
Compare
drench
commented
Sep 20, 2021
| else | ||
| val = val.encode Encoding.find('ASCII'), ENCODING_OPTIONS | ||
| end | ||
| val = val.encode(Encoding.find('ASCII'), **ENCODING_OPTIONS) |
There was a problem hiding this comment.
This adds support for 3.0 while dropping support for long-dead Rubies.
drench
deleted the
update_the_ach_gem_to_support_ruby_2_7_and_u_CORE-674
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: CORE-674