Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed taskbar not showing all apps icons #149

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

arthurferrai
Copy link
Contributor

This pull request changes taskbar icon rendering so it will look to all open programs and render all icons except the windows that won't show neither on alt-tab nor task manager (it does so by checking for WS_EX_NOREDIRECTIONBITMAP style, which is not included on win32con).

It also fixes some typing and changes some checks.

With this pull request, all taskbar icons will show even if you start yasb after a bunch of programs are opened before.

@amnweb
Copy link
Owner

amnweb commented Mar 8, 2025

@arthurferrai thanks for this PR. This is what we need. I have just made some changes in the taskbar widget to get better icon quality. Can you check your code once again, please?

@Osyx
Copy link
Contributor

Osyx commented Mar 8, 2025

Closes #150

# Conflicts:
#	src/core/widgets/yasb/taskbar.py
@arthurferrai
Copy link
Contributor Author

@arthurferrai thanks for this PR. This is what we need. I have just made some changes in the taskbar widget to get better icon quality. Can you check your code once again, please?

I've merged main into this branch and tested here, and it works as expected.

@amnweb
Copy link
Owner

amnweb commented Mar 8, 2025

Thanks, it works fine for me as well.

@amnweb amnweb merged commit 4cd5e56 into amnweb:main Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants