drm/msm: Fix return type of mdp4_lvds_connector_mode_valid

[ Upstream commit 0b33a33 ]

The mode_valid field in drm_connector_helper_funcs is expected to be of
type:
enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
                                     struct drm_display_mode *mode);

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of mdp4_lvds_connector_mode_valid should be changed from
int to enum drm_mode_status.

Reported-by: Dan Carpenter <[email protected]>
Link: ClangBuiltLinux#1703
Cc: [email protected]
Signed-off-by: Nathan Huckleberry <[email protected]>
Fixes: 3e87599 ("drm/msm/mdp4: add LVDS panel support")
Reviewed-by: Abhinav Kumar <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Patchwork: https://patchwork.freedesktop.org/patch/502878/
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>

drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c

@@ -71,8 +71,9 @@ static int mdp4_lvds_connector_get_modes(struct drm_connector *connector)
 	return ret;
 }
 
-static int mdp4_lvds_connector_mode_valid(struct drm_connector *connector,
-				 struct drm_display_mode *mode)
+static enum drm_mode_status
+mdp4_lvds_connector_mode_valid(struct drm_connector *connector,
+			       struct drm_display_mode *mode)
 {
 	struct mdp4_lvds_connector *mdp4_lvds_connector =
 			to_mdp4_lvds_connector(connector);