Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x: avoid to set serial console #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alicefr
Copy link

@alicefr alicefr commented Apr 23, 2020

The serial console and the sclpconsole conflict with this error on s390x:
qemu-system-s390x: -device sclpconsole,chardev=console: Multiple VT220 operator consoles are not supported
qemu-system-s390x: -device sclpconsole,chardev=console: SCLP event initialization failed.

We can only enable the sclpconsole console

Signed-off-by: Alice Frosi [email protected]

The serial console and the sclpconsole conflict with this error on s390x:
qemu-system-s390x: -device sclpconsole,chardev=console: Multiple VT220 operator consoles are not supported
qemu-system-s390x: -device sclpconsole,chardev=console: SCLP event initialization failed.

We can only enable the sclpconsole console

Signed-off-by: Alice Frosi <[email protected]>
@marcosps
Copy link
Contributor

marcosps commented Jul 6, 2020

LGTM. @amluto do you have a better idea to solve this issue?

@amluto
Copy link
Owner

amluto commented Jul 19, 2020

I clearly don't understand what's going on here. Without this patch, we get this:

-device sclpconsole,chardev=console
-parallel none
-net none
-echr 1
-serial none
-chardev stdio,id=console,signal=off,mux=on
-serial chardev:console
-mon chardev=console

This does indeed fail, but removing -serial none doesn't help.

Want to make a new patch that wires this up in a somewhat sensible way through architectures.py and makes the correct change to the arguments? It looks like there should be a default function that supplies -serial chardev:console and an s390x override that supplies the -device sclpconsole,chardev=console.

jsitnicki added a commit to jsitnicki/virtme that referenced this pull request Mar 21, 2022
As Alice Frosi reported (PR amluto#58), passing

    -device sclpconsole,chardev=console

together with

    -serial chardev:console

to qemu-system-s390x is not supported.

Following Andrew Lutomirski's suggestion, use the latter as the default for
configuring the serial console on all architectures but s390x, where we
override it in favor of sclpconsole.

Signed-off-by: Jakub Sitnicki <[email protected]>
@marcosps
Copy link
Contributor

I tested the solution proposed in #75, and since it's more generic I believe that we can have it merged. What do you think?

tammela pushed a commit to p4tc-dev/virtme that referenced this pull request Nov 9, 2022
As Alice Frosi reported (PR amluto#58), passing

    -device sclpconsole,chardev=console

together with

    -serial chardev:console

to qemu-system-s390x is not supported.

Following Andrew Lutomirski's suggestion, use the latter as the default for
configuring the serial console on all architectures but s390x, where we
override it in favor of sclpconsole.

Signed-off-by: Jakub Sitnicki <[email protected]>
arighi pushed a commit to arighi/virtme that referenced this pull request Nov 24, 2022
As Alice Frosi reported (PR amluto#58), passing

    -device sclpconsole,chardev=console

together with

    -serial chardev:console

to qemu-system-s390x is not supported.

Following Andrew Lutomirski's suggestion, use the latter as the default for
configuring the serial console on all architectures but s390x, where we
override it in favor of sclpconsole.

Signed-off-by: Jakub Sitnicki <[email protected]>
@arighi
Copy link
Contributor

arighi commented Apr 7, 2023

This has been merged/fixed in https://github.com/arighi/virtme

NOTE: we are trying to catch up with all the pending PR in this temporary fork. In the future we may merge everything back here if this project become active again, but for now please consider to follow also the development of arighi/virtme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants