Repository navigation
feat: set up Turborepo typecheck across all packages - #3788
Conversation
Summary of ChangesHello @amitsingh-007, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the monorepo's development workflow by integrating a comprehensive and efficient type-checking system powered by Turborepo. The changes ensure that all code, from root-level files to individual packages, is type-checked consistently, and that builds are contingent upon successful type verification. This improves overall code quality, reduces potential runtime errors, and streamlines the development process by leveraging Turborepo's caching capabilities for faster feedback. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
e26b8e0 to
b7251ad
Compare
There was a problem hiding this comment.
Code Review
This pull request does a great job of setting up a monorepo-wide typechecking pipeline using Turborepo. The configuration changes are logical and correctly scope the TypeScript checks for each part of the repository. Making the build process dependent on passing type checks is a solid improvement for code quality.
I have a couple of suggestions to refine the implementation. One is to improve the efficiency of the Turborepo task dependencies for local development, and the other is a minor cleanup regarding a potentially misplaced type declaration file. Overall, excellent work on improving the project's tooling and robustness.
61c7da2 to
f612301
Compare
Extension Size Change: -916.00 B ✅
This commit looks good, cheers 👏 |
Extension Size Change: -916.00 B ✅
This commit looks good, cheers 👏 |
Extension Size Change: -916.00 B ✅
This commit looks good, cheers 👏 |
- Configure turbo.json to run typecheck efficiently via Turborepo - Add typecheck script to root package that checks both root files and all workspace packages - Fix TypeScript configuration issues (dom/webworker lib conflicts) - Add skipLibCheck to base TypeScript config - Add typecheck script to configs package with its own tsconfig.json - Add CSS module declarations for trpc package - Fix type imports in trpc to use type-only imports - Update build task to depend on typecheck Co-Authored-By: Claude <noreply@anthropic.com>
4cee929 to
b55dbd5
Compare
Extension Size Change: -916.00 B ✅
This commit looks good, cheers 👏 |
Summary
pnpm typecheckefficiently across all packages and appsChanges
typecheckscript to check both root files (tsc --noEmit) and all packages (turbo run typecheck)typechecktask configuration and madebuilddepend on//#typecheckdom/webworkerlib conflicts, addedskipLibCheck: truetsconfig.jsonandtypecheckscriptTest plan
pnpm typecheck- should check root files and all packagespnpm typecheck --filter=<package>- should check specific package🤖 Generated with Claude Code