Skip to content

feat: set up Turborepo typecheck across all packages - #3788

Merged
amitsingh-007 merged 1 commit into
mainfrom
feat/turbo-typecheck
Jan 17, 2026
Merged

amitsingh-007 merged 1 commit into
mainfrom
feat/turbo-typecheck

Conversation

@amitsingh-007

Copy link
Copy Markdown
Owner

Summary

  • Configure Turborepo to run pnpm typecheck efficiently across all packages and apps
  • Typecheck now runs on root files, configs package, and all workspace packages
  • Build task now depends on typecheck (and lint) passing first

Changes

  • Root: Updated typecheck script to check both root files (tsc --noEmit) and all packages (turbo run typecheck)
  • turbo.json: Added proper typecheck task configuration and made build depend on //#typecheck
  • TypeScript configs: Fixed dom/webworker lib conflicts, added skipLibCheck: true
  • configs package: Added dedicated tsconfig.json and typecheck script
  • trpc package: Added CSS module declarations, changed to type-only imports

Test plan

  • Run pnpm typecheck - should check root files and all packages
  • Run pnpm typecheck --filter=<package> - should check specific package
  • Verify build depends on typecheck passing
  • Verify Turborepo caching works for subsequent runs

🤖 Generated with Claude Code

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @amitsingh-007, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the monorepo's development workflow by integrating a comprehensive and efficient type-checking system powered by Turborepo. The changes ensure that all code, from root-level files to individual packages, is type-checked consistently, and that builds are contingent upon successful type verification. This improves overall code quality, reduces potential runtime errors, and streamlines the development process by leveraging Turborepo's caching capabilities for faster feedback.

Highlights

  • Turborepo Integration for Type-Checking: Configured Turborepo to orchestrate pnpm typecheck efficiently across all packages and applications within the monorepo.
  • Expanded Type-Checking Coverage: Extended type-checking to include root-level files, the configs package, and all individual workspace packages, ensuring comprehensive type safety.
  • Build Process Dependency: Established a dependency for the build task on both lint and typecheck tasks, ensuring type safety and code quality are verified before compilation.
  • TypeScript Configuration Refinements: Resolved TypeScript library conflicts by adjusting lib configurations and introducing skipLibCheck: true in the base tsconfig to prevent issues with third-party library types.
  • Dedicated Configs Package Type-Checking: Introduced a dedicated tsconfig.json and typecheck script for the configs package to manage its specific type-checking needs independently.
  • TRPC Package Improvements: Added CSS module declarations and transitioned to type-only imports in the trpc package for improved type inference and potentially smaller bundle sizes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of setting up a monorepo-wide typechecking pipeline using Turborepo. The configuration changes are logical and correctly scope the TypeScript checks for each part of the repository. Making the build process dependent on passing type checks is a solid improvement for code quality.

I have a couple of suggestions to refine the implementation. One is to improve the efficiency of the Turborepo task dependencies for local development, and the other is a minor cleanup regarding a potentially misplaced type declaration file. Overall, excellent work on improving the project's tooling and robustness.

Comment thread packages/trpc/src/@types/css-modules.d.ts
Comment thread turbo.json
@amitsingh-007
amitsingh-007 force-pushed the feat/turbo-typecheck branch 2 times, most recently from 61c7da2 to f612301 Compare January 17, 2026 10:09
@webext-bot

webext-bot Bot commented Jan 17, 2026

Copy link
Copy Markdown
Extension Size Change:   -916.00 B ✅
Commit 61c7da2
Latest release size 179.13 KB
Current size 178.23 KB
Percent change -0.50 %

This commit looks good, cheers 👏

@webext-bot

webext-bot Bot commented Jan 17, 2026

Copy link
Copy Markdown
Extension Size Change:   -916.00 B ✅
Commit f612301
Latest release size 179.13 KB
Current size 178.23 KB
Percent change -0.50 %

This commit looks good, cheers 👏

@amitsingh-007 amitsingh-007 linked an issue Jan 17, 2026 that may be closed by this pull request
@webext-bot

webext-bot Bot commented Jan 17, 2026

Copy link
Copy Markdown
Extension Size Change:   -916.00 B ✅
Commit 4cee929
Latest release size 179.13 KB
Current size 178.23 KB
Percent change -0.50 %

This commit looks good, cheers 👏

- Configure turbo.json to run typecheck efficiently via Turborepo
- Add typecheck script to root package that checks both root files and all workspace packages
- Fix TypeScript configuration issues (dom/webworker lib conflicts)
- Add skipLibCheck to base TypeScript config
- Add typecheck script to configs package with its own tsconfig.json
- Add CSS module declarations for trpc package
- Fix type imports in trpc to use type-only imports
- Update build task to depend on typecheck

Co-Authored-By: Claude <noreply@anthropic.com>
@webext-bot

webext-bot Bot commented Jan 17, 2026

Copy link
Copy Markdown
Extension Size Change:   -916.00 B ✅
Commit b55dbd5
Latest release size 179.13 KB
Current size 178.23 KB
Percent change -0.50 %

This commit looks good, cheers 👏

@amitsingh-007
amitsingh-007 merged commit 64e250f into main Jan 17, 2026
4 checks passed
@amitsingh-007
amitsingh-007 deleted the feat/turbo-typecheck branch January 17, 2026 10:23
This was referenced Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup typechecking

1 participant