Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Serving on Generic net.Listener #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianosela
Copy link

Support for Serving on Generic net.Listener

Adds the ability to initialize a VncProxy object with your own net.Listener.

Example:

Where ln is a net.Listener implementation

	proxy := &vncproxy.VncProxy{
		NetListener: ln,
		ProxyVncPassword: "server-password",
		SingleSession: &vncproxy.VncSession{
			TargetHostname: "127.0.0.1",
			TargetPort:     "5900",
			TargetPassword: "target-password"
			ID:             "dummySession",
			Status:         vncproxy.SessionStatusInit,
			Type:           vncproxy.SessionTypeProxyPass,
		},
		UsingSessions: false,
	}

This is useful to me because I have a listener that does end to end encryption and other additional functionality. It's basically a TCP connection with LOTS of middlewares - abstracted as a net.Listener. I would love for the vnc proxy to accept connections over this net.Listener.

@adrianosela
Copy link
Author

@amitbet it would mean a lot to me for this change to be reviewed :) thanks for the awesome work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant