Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sqlAlchemy 2.0 #76

Open
Bensebabillal opened this issue Feb 24, 2023 · 6 comments
Open

Support for sqlAlchemy 2.0 #76

Bensebabillal opened this issue Feb 24, 2023 · 6 comments

Comments

@Bensebabillal
Copy link

Bensebabillal commented Feb 24, 2023

Hi guys,

Con we add support for sql alchemy 2.0 please ?

Thank you

@amisadmin
Copy link
Owner

Yes, sqlalchemy 2.0 support will begin after pydantic V2 is released.

@honglei
Copy link

honglei commented Jun 7, 2023

pydantic V2 is not needed for supporting sqlalchemy2.0:
migration to sqlalchemy 2.0

admin.py:
insfield.prop.secondary -> insfield.property.secondary

_sqlmodel.py:
stmt.with_only_columns([self.pk])->stmt.with_only_columns(self.pk)

@amisadmin
Copy link
Owner

pydantic V2 is not needed for supporting sqlalchemy2.0: migration to sqlalchemy 2.0

admin.py: insfield.prop.secondary -> insfield.property.secondary

_sqlmodel.py: stmt.with_only_columns([self.pk])->stmt.with_only_columns(self.pk)

Thank you for your feedback. I've been following the sqlmodel project.

@mikoda1995
Copy link

@amisadmin firstly thank you for this project. Do you have any plans to support sqlalchemy 2.0 now?

@peter65374
Copy link

it seems that sqlalchemy 2.0 was supported now. 👍

@mikoda1995
Copy link

it seems that sqlalchemy 2.0 was supported now. 👍

yep, but seems fastapi-user-auth is still depends on sqlmodel and fastapi-amis-admin<0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants