fix: allow specifying the vcpkg version + fix: fix check for apt package installs + feat: allow parallel apt-get calls #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
changed the title
aminya
changed the title
bjosv
reviewed
Aug 17, 2024
| @@ -70,16 +70,16 @@ function nonInteractiveScript(script: string) { | |||
| // make the scirpt non-interactive and fix broken packages | |||
| return script.replace( | |||
| /add-apt-repository "\${REPO_NAME}"/g, | |||
| // eslint-disable-next-line no-template-curly-in-string | |||
| "add-apt-repository -y \"${REPO_NAME}\"", | |||
| `add-apt-repository -y -n "\${REPO_NAME}" | |||
There was a problem hiding this comment.
The downloaded llvm.sh script contains add-apt-repository -y "${REPO_NAME}" so I don't think this replacement will be done.
The script also has an update afterwards which could be patch instead of adding the apt-get update.
There was a problem hiding this comment.
Looks like they added the flag recently. The code needs to be updated. Thanks for catching this.
opencollab/llvm-jenkins.debian.net@33f9c64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22