Skip to content

add llvm 18 support #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tchaikov opened this issue Feb 1, 2024 · 2 comments · Fixed by #236
Closed

add llvm 18 support #228

tchaikov opened this issue Feb 1, 2024 · 2 comments · Fixed by #236

Comments

@tchaikov
Copy link
Contributor

tchaikov commented Feb 1, 2024

since llvm 18 is around the corner, can we add support for it? i will create a pull request for this if this is acceptable. it would be great if we can even support llvm 19. as, under some circumstances, we need to test the compatibility of a library to see if it is compatible with the latest clang. i would be happy to create a pull request for this as well.

@aminya
Copy link
Owner

aminya commented Feb 19, 2024

We should wait for the release
https://github.com/llvm/llvm-project/releases

Once released 18 should be added to this for the URL-based installers

export const VERSIONS: Set<string> = getVersions([

And the default version should be updated here:
https://github.com/aminya/setup-cpp/blob/master/src/versions/default_versions.ts

@aminya
Copy link
Owner

aminya commented Mar 14, 2024

@tchaikov LLVM18 is released with binaries. would you want to make a PR?

tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 18, 2024
specifically, 18.1.2 has not been tagged yet. but its ubuntu packages
have been uploaded. so add this version to ubuntu's mapping as well.

Fixes aminya#228
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 18, 2024
specifically, 18.1.2 has not been tagged yet. but its ubuntu packages
have been uploaded. so add this version to ubuntu's mapping as well.

Fixes aminya#228
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 18, 2024
specifically, 18.1.2 has not been tagged yet. but its ubuntu packages
have been uploaded. so add this version to ubuntu's mapping as well.

Fixes aminya#228
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 18, 2024
specifically, 18.1.2 has not been tagged yet. but its ubuntu packages
have been uploaded. so add this version to ubuntu's mapping as well.

Fixes aminya#228
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 18, 2024
specifically, 18.1.2 has not been tagged yet. but its ubuntu packages
have been uploaded. so add this version to ubuntu's mapping as well.

Fixes aminya#228
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 19, 2024
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 21, 2024
tchaikov added a commit to tchaikov/setup-cpp that referenced this issue Mar 21, 2024
aminya pushed a commit to tchaikov/setup-cpp that referenced this issue Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants