-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable gcc sanitizer on macos by default #255
fix: Disable gcc sanitizer on macos by default #255
Conversation
0fd0926
to
6337d19
Compare
According to https://github.com/orgs/Homebrew/discussions/3384#discussioncomment-6264292, gcc now dosen't support libsanitizer on macOS with arm64 and macOS Ventuna or later with x86_64.
6337d19
to
c41a9e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this issue didn't happen inside CI. We should be able to reproduce it to disable it?
The issue happens inside the DynamicProjectOptions.cmake, which sets UBSAN and ASAN for gcc by default (except for windows):
So use |
Convert to a draft until
|
c12844b
to
040d9b1
Compare
d97c0df
to
f5e7f3a
Compare
- Make sanitizer enabling in dynamic_project_options consistent with detect_sanitizers_support. - detect MacOS OS version to keep gcc sanitizers enable on x86_64 macOS Monterey or older.
51c3eff
to
6f25c7f
Compare
Ready to merge. changes:
|
Thanks for the investigation. It would be great if you could create an issue for the upstream so that they can look into the problem. |
Although no related issue, it seems that the upstream already knows the issue and chooses not to support this for now (see iains/gcc-darwin-arm64@e722a1f). |
According to this comment, gcc now dosen't support libsanitizer on macOS with arm64 and macOS Ventuna or later with x86_64.